Jay Fitzgerald

Results 47 comments of Jay Fitzgerald

If we do set a threshold, we may need to combine the coverage for the unit tests and session tests for some files, first, as @bkeryan suggested in https://github.com/ni/nimi-python/issues/2015#issuecomment-1723637342 (perform...

We were not using persistent simulation. It was IVI simulation.

Sorry, I meant this part, specifically, is not unique to the Python API. >Note: if it supported options, you would still have to specify the topology key instead of the...

I prefer to wait until we drop Python 3.8, before adding type hints, due to the major differences in how collections are annotated between 3.8 and 3.9: https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html#useful-built-in-types

Based on what @marcoskirsch has told me, we should have done something like this with an enum for each of these properties: ``` 'IsolationState': { 'codegen_method': 'private', 'converted_value_to_enum_function_name': 'convert_to_isolation_state_enum', 'enum_to_converted_value_function_name':...

When fixing this, we should also update test_lcr_compensation_data to run for both the Library and the GrpcStubInterpreter.

@mgallatin @marcoskirsch Well, this is a bit embarrassing for us. It looks like I created a similar issue 3 years ago and we still haven't addressed it. #1480

>Since we seem to only test 3 APIs on each nimibot at once, I suspect this is being set to 3 based upon the existence of 3 runners, despite the...

We are most likely overwriting the junit .xml when we run the system tests. We should have the example testing and system testing write to separate junit xmls.