nhsuk-frontend icon indicating copy to clipboard operation
nhsuk-frontend copied to clipboard

Published 20 hours ago • verified publisher icon nhsuk

fixed transactional header layout

Open xLasercut opened this issue 4 years ago • 3 comments

Description

Fixed layout issue. service flag now controls both transactional and normal service names/href/longname etc. Header will become transactional if transactional is set while showNav and showSearch are both false

Checklist

xLasercut avatar Nov 15 '19 20:11 xLasercut

Hey @xLasercut thanks for having a look at this.

I'm abit wary of doing another breaking change so soon - is there any fix for this without a breaking change? We are planning another breaking change in the new year, where we could include this and any other feedback from the new header.

chrimesdev avatar Nov 18 '19 10:11 chrimesdev

This fix makes the most sense. I guess you can delay this until Jan since it's not too big of an issue

xLasercut avatar Nov 18 '19 13:11 xLasercut

To be reviewed for release 5.0.0 along with https://github.com/nhsuk/nhsuk-frontend/issues/561 & https://github.com/nhsuk/nhsuk-frontend/issues/563 and

chrimesdev avatar Jan 15 '21 11:01 chrimesdev