nhsuk-frontend icon indicating copy to clipboard operation
nhsuk-frontend copied to clipboard

Header navigation bar colour not full width when no organisation

Open xLasercut opened this issue 5 years ago • 3 comments

Bug Report

What is the issue?

Header navigation bar colour does not extend to full width of the screen unless nhsuk-header--organisation class is set on the main header tag (this is only set if organisation details are present)

using this would give

  {{ header({
      "showNav": "true",
      "showSearch": "true",
      "classes": "nhsuk-header--white-nav",
      "primaryLinks": [
        {
          "url"  : "https://www.nhs.uk/conditions",
          "label" : "Health A-Z"
        },
        {
          'url' : 'https://www.nhs.uk/live-well/',
          'label' : 'Live Well'
        },
        {
          'url'  : 'https://www.nhs.uk/conditions/social-care-and-support/',
          'label' : 'Care and support'
        },
        {
          'url'  : 'https://www.nhs.uk/news/',
          'label' : 'Health news'
        },
        {
          'url' : 'https://www.nhs.uk/service-search',
          'label' : 'Services near you'
        }
      ]
    })
  }}

header_no_org2

It's the same for white header and blue nav

What was the environment where this issue occurred?

  • Device: All Devices
  • Operating System: All OS
  • Browser: Firefox, Chrome
  • Browser version:
  • NHS.UK frontend package version: 3.0.1
  • Node version:
  • npm version:

xLasercut avatar Nov 10 '19 20:11 xLasercut

Hey Tim (@xLasercut) thanks for opening this issue, the team will triage this get back to you on it.

The organisational header is an experimental component so we need to do abit more testing on this and decide whether the white navigation variant can only be used with the organisational header or with the main header too.

chrimesdev avatar Nov 11 '19 10:11 chrimesdev