nhsuk-frontend icon indicating copy to clipboard operation
nhsuk-frontend copied to clipboard

In nightmode make the NHS logo reverse colour

Open GrilloPress opened this issue 4 years ago • 4 comments

NHS App team have been tested night mode for the app.

Most of the frontend holds up well 🙂

But the NHS logo doesn't match the mode.

  1. Decide if this is a problem
  2. What it should look like in nightmode
  3. Find a way of getting it to look like that

image

GrilloPress avatar Oct 24 '19 16:10 GrilloPress

Hey Andrew, thanks for raising this. I think its definitely something we should look into as night mode is becoming ever more popular. I use it on iOS and MacOS but the logo is fine so it must be different behaviour on Android. Something to explore.

The team will triage this issue and see if it's something we can pick up or put it out to the community.

chrimesdev avatar Oct 28 '19 09:10 chrimesdev

Hello, me and @AdamChrimes found that the colours seem to change differently on dark mode. i'll test and share the NHS logo on dark mode on other androids over the next few days to see what other results we get.

screenshot_20191029_101531_com android chrome

Huawei p20 Pro android version 9 emuy 9.1.0 google chrome 77.0.3865.116

misakihata avatar Oct 29 '19 10:10 misakihata

black on dark blue nhs logo

This appeared on two users on android 8 and 9

misakihata avatar Oct 29 '19 11:10 misakihata

Came across this on Twitter which may be of use to fixing this: https://developers.google.com/web/updates/2019/10/devtools#userpreferences

https://web.dev/prefers-color-scheme/

chrimesdev avatar Nov 04 '19 15:11 chrimesdev