nhsuk-frontend icon indicating copy to clipboard operation
nhsuk-frontend copied to clipboard

Hero image with image, heading and content margin

Open chrimesdev opened this issue 6 years ago • 2 comments

When using the Hero with image, heading, and content there is no bottom responsive margin below the Hero component, so any content placed within the page after this component is hidden behind the blue content section of the header.

Example (with h2 element hidden behind the hero image)

Screenshot 2019-04-02 at 11 14 34

Example (with different content length and promo group component)

Screenshot 2019-04-02 at 11 33 25

On the NHS.UK homepage, a responsive top margin is added to the content section to fix this. However, our spacing should always be in a single downwards direction and the spacing should be applied to the hero component instead. The margins might change depending on how much content you have in the blue section.

Screenshot 2019-04-02 at 11 13 48

I've also tried adding padding to the section below the hero component

Screenshot 2019-04-02 at 11 38 35

chrimesdev avatar Apr 02 '19 10:04 chrimesdev

I've referenced this issue in the NHS.UK JIRA board to gauge interest in it being picked up (CITR-574). If someone picks this up, please mention here to avoid any duplicated effort.

theonlymojo avatar Aug 09 '19 10:08 theonlymojo