NHSRdatasets
NHSRdatasets copied to clipboard
nhs-r-community
Synthetic NEWS vignette
Currently, in the synthetic news data vignette, the data is loaded directly from a url.
This is a potential issue for rendering with CRAN: occasionally file downloads can fail, which will cause the vignette to error. If this happens, CRAN can archive the package.
If the vignette is to remain as it is, this file should be directly included within the package (in the inst/ directory).
However, I think this vignette is a little out of place for this package. The other vignettes detail the source of the data, and then simple examples of how to use the data. This vignette instead explains how to generate the data, which feels out of scope for this package (there is already a blog post on the subject), and nothing about useful ways of using this data for learning purposes.
Agreed, there are also a lot of package dependencies because of the vignettes. We need simpler vignettes and these can also be linked to the NHSR courses.
The vignettes currently could be moved to the repo Demos and How to so they don't get lost. Then perhaps link to them from here or is that a similar issue with CRAN? Would it be on the README?
