hasura-auth icon indicating copy to clipboard operation
hasura-auth copied to clipboard

feat(sms): support for templates for the sms message

Open azlekov opened this issue 2 years ago • 1 comments

Before submitting this PR:

Checklist

  • [x] No breaking changes
  • [x] Tests pass
  • [x] New features have new tests
  • [x] Documentation is updated

Breaking changes

Avoid breaking changes and regressions. If you feel it is unavoidable, make it explicit in your PR comment so we can review it and see how to handle it.

Tests

  • please make sure your changes pass the current tests (Use the make test or the make watch command).
  • if you are introducing a new feature, please write as much tests as possible.

Documentation

Please make sure the documentation is updated accordingly, in particular:

Conventional commits

Versioning and changelog are generated following conventional commits. Please do your best to follow the convention, but don't worry about it too much. We will be most likely moving away to changesets soon.

Closes #196

azlekov avatar Jul 21 '22 14:07 azlekov

@elitan can you check this?

azlekov avatar Jul 21 '22 14:07 azlekov

@elitan @plmercereau any ideas when this could be reviewed, merged and shipped?

azlekov avatar Aug 22 '22 12:08 azlekov

@elitan @plmercereau any ideas when this could be reviewed, merged and shipped?

We are needing this PR merged too, we cannot send SMS in english.

smiziara avatar Aug 22 '22 18:08 smiziara

@elitan Can we prioritize merging this?

elleryfamilia avatar Sep 08 '22 03:09 elleryfamilia

Sorry for the delay, I will review this PR next week. I've put time in my calendar for it.

elitan avatar Sep 09 '22 13:09 elitan