hasura-auth
hasura-auth copied to clipboard
feat(sms): support for templates for the sms message
Before submitting this PR:
Checklist
- [x] No breaking changes
- [x] Tests pass
- [x] New features have new tests
- [x] Documentation is updated
Breaking changes
Avoid breaking changes and regressions. If you feel it is unavoidable, make it explicit in your PR comment so we can review it and see how to handle it.
Tests
- please make sure your changes pass the current tests (Use the
make test
or themake watch
command). - if you are introducing a new feature, please write as much tests as possible.
Documentation
Please make sure the documentation is updated accordingly, in particular:
- Workflows. Workflows are Mermaid sequence diagrams
- Schema. The schema in a Mermaid ER diagram
- Environment variables. Please adjust the .env.example file accordingly
- OpenApi specifications. We are using inline JSDoc annotations
Conventional commits
Versioning and changelog are generated following conventional commits. Please do your best to follow the convention, but don't worry about it too much. We will be most likely moving away to changesets soon.
Closes #196
@elitan can you check this?
@elitan @plmercereau any ideas when this could be reviewed, merged and shipped?
@elitan @plmercereau any ideas when this could be reviewed, merged and shipped?
We are needing this PR merged too, we cannot send SMS in english.
@elitan Can we prioritize merging this?
Sorry for the delay, I will review this PR next week. I've put time in my calendar for it.