Neil Horman

Results 475 comments of Neil Horman

I'll save approval until after the re-targeting, but it looks good to me.

can you please sign the CLA: https://openssl-library.org/policies/cla/ So we can review this patch please? Also, it looks like you have some whitespace in your code that the style checker is...

Marking as inactive, to be closed at the end of the 3.4 dev cycle, barring further input

Its hard to tell from the backtrace, but this feels alot like This issue: https://github.com/openssl/openssl/issues/24480 With a debug symbol enabled backtrace, we could tell more, as in the analysis [here](https://github.com/openssl/openssl/issues/24480#issuecomment-2127762716)...

Just seeing the assembly of a few places where you encountered an error doesn't really help I diagnosing the problem. You need to figure out why your able to do...

yeah, it looks like we had some ships cross in the night. We need to update the new x86 tests to not try build with sslv3. @andrewkdinh would you be...

Note: Codespell is failing above, but it appears to be due to some spelling errors that have entered prior to this branch being updated (specifically commit 9a5ac06921357bdfd4e2f74b5b32955464bf9b75 back in may)....

Thats.... a odd one. I would think that, yes, it at least in part has to do with the differences between the msquic-shipping openssl and the system installed instance, but...

that is interesting. If I build like you are, using cmake directly: ``` nhorman@hmsbeagle:~/git/msquic$ mkdir build nhorman@hmsbeagle:~/git/msquic$ cd build nhorman@hmsbeagle:~/git/msquic/build$ cmake -DCMAKE_BUILD_TYPE=Debug -DQUIC_BUILD_TOOLS=off -DQUIC_BUILD_TEST=off -DQUIC_BUILD_PERF=off -DQUIC_ENABLE_LOGGING=true -DQUIC_USE_SYSTEM_LIBCRYPTO=true -DQUIC_TLS_LIB=openssl .. ......