websocket icon indicating copy to clipboard operation
websocket copied to clipboard

Update dependencies to latest versions

Open Jacalz opened this issue 2 years ago • 5 comments

This modernizes the imported packages a lot by updating to the latest releases. It should bring many improvements and a fix for https://github.com/nhooyr/websocket/issues/318. The protobuf package should probably be updated to "google.golang.org/protobuf/proto" but this is at least better than before.

Jacalz avatar Mar 05 '22 13:03 Jacalz

Thank you @Jacalz I've forked your fork and created a release for myself, which im using until @nhooyr answers.

ohaeusler avatar Mar 07 '22 12:03 ohaeusler

Cool @ohaeusler. There is another option if you don’t want to carry fork through. If you update the above packages inside your own module instead, they will be added as indirect dependencies and overwrite what this project uses (for that specific module) :)

Jacalz avatar Mar 07 '22 13:03 Jacalz

@nhooyr Any chance that you'd be able to review this?

Jacalz avatar Mar 17 '22 11:03 Jacalz

Any updates on this? Mainly concerned about https://github.com/advisories/GHSA-h395-qcrw-5vmq.

ryanchristo avatar Aug 15 '22 15:08 ryanchristo

Until this repository is maintained, I will continue to update the dependencies in https://github.com/rymdport/websocket. However, I have enough on my plate already and can not guarantee any bug fixes or features being implemented.

Jacalz avatar Aug 15 '22 15:08 Jacalz

I cannot merge this in due to other pending changes. I'm going to be removing all of these dependencies from the test code and move the tests that use them into a separate module. See #297

nhooyr avatar Mar 07 '23 14:03 nhooyr

Though thank you for your work @Jacalz and sorry I've been unresponsive.

nhooyr avatar Mar 07 '23 14:03 nhooyr

@nhooyr It's great to see you being active again. I'll go ahead and delete my fork once you have implemented those changes (and has the project entirely up and running again) :)

Jacalz avatar Mar 07 '23 15:03 Jacalz