units icon indicating copy to clipboard operation
units copied to clipboard

Failing UnitContainer.to_string_locale test

Open JohelEGP opened this issue 6 years ago • 2 comments

The test that does setlocale(6, "de_DE.utf8") fails because I'm using Arch Linux, and during installation we explicitly enable the locales we're interested in.

JohelEGP avatar May 13 '18 03:05 JohelEGP

I'll set some environment variable to only run that on the CI

On Sat, May 12, 2018, 11:02 PM Johel Ernesto Guerrero Peña < [email protected]> wrote:

The test that does setlocale(6, "de_DE.utf8") fails because I'm using Arch Linux, and during installation we explicitly enable the locales we're interested in.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/nholthaus/units/issues/127, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ2HHweRSDQlXO-jgCH4cnQBXmZxHSsRks5tx6IwgaJpZM4T8o-u .

nholthaus avatar May 13 '18 19:05 nholthaus

You could also test that the call to setlocale didn't return nullptr. I'd do it, but the conditional compilation to work around MSVC makes me unsure on how to do it cleanly.

JohelEGP avatar Jul 22 '18 17:07 JohelEGP