jekyll-postfiles icon indicating copy to clipboard operation
jekyll-postfiles copied to clipboard

Published 20 hours ago • verified publisher icon nhoizey

Collections

Open mohkale opened this issue 5 years ago • 7 comments

add collection support alongside regular _posts support.

see issue #18

closes #19

I've tested this on my site, but I'd appreciate if you could do so as well. I was unable to run the :spec rake task because of gem issues 😭.

mohkale avatar Jan 03 '20 16:01 mohkale

This is a great addition, someone please merge it

jordikitto avatar Oct 01 '20 05:10 jordikitto

Not to be that guy that advertises another project in a PR for a project, but I'd recommend looking into Hugo @jordikitto. I've found it to be a much more stable and feature full SSG that has builtin support for things like jekyll-postfiles.

mohkale avatar Oct 01 '20 12:10 mohkale

@mohkale I didn't test yet, but read the code, and I see there's a comment saying there's an issue with "the collection still generates a StaticFile instance for the post file". Is that still true?

BTW, I started adding rspec tests to the project, so it might be a good idea enhancing those tests before merging this PR.

Thanks.

nhoizey avatar Oct 03 '20 20:10 nhoizey

@nhoizey it's been a while so I'll double check when I get a chance. I'm pretty sure I fixed that issue when I encountered it. As for RSpec tests, I'll try to add test coverage for this PR when I can.

mohkale avatar Oct 03 '20 20:10 mohkale

@mohkale thanks!

nhoizey avatar Oct 03 '20 21:10 nhoizey

Just curious on the status of this PR. Such lovely work has been done, is there a reason we haven't merged it yet?

MikeWeiZhou avatar Jul 30 '23 03:07 MikeWeiZhou

Honestly I've lost motivation for this. If someone else wants to pickup the work and push it to the goal line then please do.

mohkale avatar Jul 30 '23 09:07 mohkale