Nicolas Höning

Results 111 comments of Nicolas Höning

Also, some code is not needed at the moment, as we changed what pages are being used (i.e. analytics is out). This issue should do the cleanup there, or comment...

One thing to consider: We might add a data migration, so existing data sources for scheduling also get model and version information. But we haven't distinguished so far between the...

> And are you sure we shouldn't go with scheduler classes instead of functions, before opening up scheduler customisation to users? > > ``` > class StorageScheduler(BaseScheduler): > __author__ =...

Yes I found out about them, as well. Is your idea that the parameter decides which data source to use?

I'd very happily skip making that migration, but you're the better judge here.

Places with hard-coded "Seita" data source for scheduling: - flexmeasures/api/v1_3/implementations.py l. 147f - flexmeasures/api/v1_3/tests/test_api_v1_3.py l. 93 - flexmeasures/api/v3_0/sensors.py l. 521 - flexmeasures/api/v3_0/tests/test_sensor_schedules.py l. 71 - flexmeasures/data/services/scheduling.py l. 148 - flexmeasures/data/tests/test_scheduling_jobs.py...

Let's close. When we throw out older code, we'll see better if we forgot anything .

Please, I need a description what this PR is doing. That's usually in the PR description. There are two env settings handled now, and some refactoring. What is the big...

This issue has as motivation "the issue where the documentation was unable to build". That issue seems fine, looking at https://readthedocs.org/projects/flexmeasures/builds/ So I assume the motivation is now a refactoring...