tui.image-editor icon indicating copy to clipboard operation
tui.image-editor copied to clipboard

call `addText` method and revise immediately `space` not working

Open eomttt opened this issue 3 years ago β€’ 6 comments

Describe the bug when i use addText method. textarea open and focusing but when i typing english or number and after typing space focus out textarea but korean is work very well (but when i typing korean and after click space twice, fire same)

example

abc(space)<- focus out
123(space)<- focus out
κ°€λ‚˜λ‹€(space)λΌλ§ˆλ°”μ‚¬<- work well
κ°€λ‚˜λ‹€(space)(space)<-focus out

and it also fire at first time when i call addText and delete placeholder and same typing above doesn't file only fire when call addText and immediately write. so i think it's problem with addText method

To Reproduce Steps to reproduce the behavior:

  1. Go to 'call addText method'
  2. Typing any text and type space after
  3. textarea focused out -> but when i double click textarea after focus out and revise work very well

Expected behavior Not focusing out

Screenshots https://user-images.githubusercontent.com/22593217/153546996-12e96507-f4e0-4a1f-94b1-f2eb3dff7f29.mov

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

eomttt avatar Feb 11 '22 06:02 eomttt

i debug some case. when i click space textarea tag detached in body tag at first time

eomttt avatar Feb 11 '22 08:02 eomttt

i forked repo and make new html for test my issue https://github.com/eomttt/tui.image-editor/commit/456921f7c4900fb1190b25c4aaa7794f9bdfa811

open dev serve and check please

eomttt avatar Feb 11 '22 09:02 eomttt

https://user-images.githubusercontent.com/22593217/153568856-fe4eea90-261e-4d1b-bafa-8ed0337b9e74.mov

eomttt avatar Feb 11 '22 09:02 eomttt

@eomttt Thank you for reporting the bug. The bug is not reproduced. Can you tell me how to reproduce it in detail?

lja1018 avatar Feb 16 '22 05:02 lja1018

@eomttt Thank you for reporting the bug. The bug is not reproduced. Can you tell me how to reproduce it in detail?

You can see my commit (https://github.com/eomttt/tui.image-editor/commit/456921f7c4900fb1190b25c4aaa7794f9bdfa811) and show example04-add-text.html file and produce this html in your dev server.

ν•œκ΅­λ§λ‘œ ν•˜μžλ©΄.... addText λ©”μ†Œλ“œ μ‹€ν–‰ ν›„, ν…μŠ€νŠΈλ°•μŠ€κ°€ 생기면 κ·Έλ•Œ ν•œκΈ€μ„ μ œμ™Έν•œ μ˜μ–΄λ‚˜ 숫자λ₯Ό μž…λ ₯ν•˜λ‹€κ°€ 슀페이슀λ₯Ό μž…λ ₯ν•˜λ©΄ ν…μŠ€νŠΈ λ°•μŠ€μ—μ„œ ν¬μ»€μŠ€κ°€ μ•„μ›ƒλ©λ‹ˆλ‹€. ν•œκΈ€ 인경우 μ—°μ†μœΌλ‘œ 슀페이슀λ₯Ό 치면 ν…μŠ€νŠΈ λ°•μŠ€μ—μ„œ ν¬μ»€μŠ€κ°€ μ•„μ›ƒλ©λ‹ˆλ‹€.

쑰금 μ½”λ“œλ₯Ό μ°Ύμ•„λ³΄λ‹ˆ autofocus 인 κ²½μš°μ— events.TEXT_EDITING μ΄λ²€νŠΈκ°€ λ°œμƒ μ•ˆλ˜μ–΄μ„œ zoom.js μ—μ„œ _startHandModeWithSpaceBar λ©”μ†Œλ“œμ—μ„œ this.isTextEditing 이 아직 false μ—¬μ„œ μŠ€νŽ˜μ΄μŠ€μ‹œ this.startHandMode λ©”μ†Œλ“œκ°€λΆˆλ €μ„œ ν¬μ»€μŠ€κ°€ μ—†μ–΄μ§‘λ‹ˆλ‹€.

rκ·Έλž˜μ„œ PR 도 μ—΄μ–΄ λ΄€μŠ΅λ‹ˆλ‹€. (https://github.com/nhn/tui.image-editor/pull/711)

eomttt avatar Feb 16 '22 05:02 eomttt

@eomttt I succeeded in reproducing it. Thank you for the information. I will comment on the PR.

lja1018 avatar Feb 16 '22 07:02 lja1018