fix: link mark no longer building with misnamed getCustomAttrs (fix #2687, #2671, #2730)
Please check if the PR fulfills these requirements
- [x] It's the right issue type on the title
- [x] When resolving a specific issue, it's referenced in the PR's title (e.g.
fix #xxx[,#xxx], where "xxx" is the issue number) - [x] The commit message follows our guidelines
- [ ] Tests for the changes have been added (for bug fixes/features)
- [ ] Docs have been added/updated (for bug fixes/features)
- [x] It does not introduce a breaking change or has a description of the breaking change
I'm not fully sure why but the cast or comment on the changed lines caused the bundler to compile the code wrong. I found this fix by accident by removing the unnecessary cast.
There aren't tests that I saw which test the compiled output of the editor so it wasn't obvious to me how to write a unit test for this bug.
Would love to get this merged ASAP. This is a pretty big issue for an application I'm working on
I have the same issue. whenever I add a link into markdown editor it breaks wysiwyg mode.
Is @jajugoguma the maintainer?
@jajugoguma Merging this fix would be appreciated. Thank you
Is @jajugoguma the maintainer?
I think @jwlee1108 is also a maintainer on this project?
I've been busy with another project. I'll check it out as soon as I can.
Awesome. Will there be a release setup soon?
@jethrolarson It release with v3.2.1. if you use react or vue wrapper, you need to install v3.2.2 (I missed the editor version dependency on the wrapper package distribution.)
@jwlee1108 new release fixed everything for me :+1: