tui.editor icon indicating copy to clipboard operation
tui.editor copied to clipboard

fix: link mark no longer building with misnamed getCustomAttrs (fix #2687, #2671, #2730)

Open jethrolarson opened this issue 1 year ago • 5 comments

Please check if the PR fulfills these requirements

  • [x] It's the right issue type on the title
  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [x] The commit message follows our guidelines
  • [ ] Tests for the changes have been added (for bug fixes/features)
  • [ ] Docs have been added/updated (for bug fixes/features)
  • [x] It does not introduce a breaking change or has a description of the breaking change

I'm not fully sure why but the cast or comment on the changed lines caused the bundler to compile the code wrong. I found this fix by accident by removing the unnecessary cast.

jethrolarson avatar Sep 12 '22 21:09 jethrolarson

There aren't tests that I saw which test the compiled output of the editor so it wasn't obvious to me how to write a unit test for this bug.

jethrolarson avatar Sep 12 '22 21:09 jethrolarson

Would love to get this merged ASAP. This is a pretty big issue for an application I'm working on

spencerpowell avatar Sep 13 '22 15:09 spencerpowell

I have the same issue. whenever I add a link into markdown editor it breaks wysiwyg mode.

benderillo avatar Sep 16 '22 02:09 benderillo

Is @jajugoguma the maintainer?

jethrolarson avatar Sep 16 '22 17:09 jethrolarson

@jajugoguma Merging this fix would be appreciated. Thank you

Recurse-blip avatar Sep 19 '22 23:09 Recurse-blip

Is @jajugoguma the maintainer?

I think @jwlee1108 is also a maintainer on this project?

IgorClouder avatar Sep 22 '22 13:09 IgorClouder

I've been busy with another project. I'll check it out as soon as I can.

jwlee1108 avatar Sep 22 '22 15:09 jwlee1108

Awesome. Will there be a release setup soon?

jethrolarson avatar Sep 27 '22 17:09 jethrolarson

@jethrolarson It release with v3.2.1. if you use react or vue wrapper, you need to install v3.2.2 (I missed the editor version dependency on the wrapper package distribution.)

jwlee1108 avatar Sep 29 '22 13:09 jwlee1108

@jwlee1108 new release fixed everything for me :+1:

luke-goddard avatar Sep 29 '22 14:09 luke-goddard