tui.editor icon indicating copy to clipboard operation
tui.editor copied to clipboard

fix: popups in shadow dom closing on click on them

Open extempl opened this issue 3 years ago • 1 comments

This PR fixes the issue with popups in shadow dom, as the editor using the global document to track click and event.target (which is === to shadow root on global level, so never close to the popup). I added custom parameter so the document can be specified. Although, not sure I did it correctly. I also added global document click handler aside of custom document (if the custom one is different from global one), this was done to hide popup when the click is happened outside of the shadow dom.

extempl avatar Jun 20 '22 10:06 extempl

This issue has been automatically marked as inactive because there hasn’t been much going on it lately. It is going to be closed after 7 days. Thanks!

stale[bot] avatar Jul 31 '22 03:07 stale[bot]

This issue will be closed due to inactivity. Thanks for your contribution!

stale[bot] avatar Aug 13 '22 06:08 stale[bot]

😞

extempl avatar Aug 15 '22 09:08 extempl

@extempl I can't believe this was just auto-closed. I am dealing with the same issue and not looking forward to hacking this in.

csuwildcat avatar Oct 13 '23 20:10 csuwildcat

@csuwildcat The tui.editor seems more like dead than alive, so hacking is exactly what I did until we'll be able to get rid of shadow dom from our project 😄. We're using it in our project as is to apply the fix directly

"@toast-ui/editor": "https://gitpkg.now.sh/extempl/tui.editor/apps/editor?dist",

extempl avatar Oct 14 '23 04:10 extempl