merge-request-integration icon indicating copy to clipboard operation
merge-request-integration copied to clipboard

Add support for Webstorm 2021.1.3

Open veseo opened this issue 3 years ago • 5 comments

Can we have support for the newest Webstorm (2021.1.3 as of the moment of writing)?

veseo avatar Nov 16 '21 13:11 veseo

I have started to create a version that loads with intelliJ 2021.3 but I need some time to test it and maybe some help for finding and fixing some issues

marcelloceschia avatar Dec 08 '21 08:12 marcelloceschia

@nhat-phan wish you the best for 2022! I'm interested in your plugin but it's incompatible with my 2021.2.3 intellij version. Do you plan to upgrade the plugin or can i work on it on the basis of changes that @marcelloceschia performed ? Regards, /DV

doumdoum avatar Jan 03 '22 09:01 doumdoum

@doumdoum Happy new Year to all of us. I did a new version for 2021.2.3 last year, you can find it here: https://github.com/marcelloceschia/merge-request-integration/releases I would love if you can test it too, we did it a bit at the end of last year, but not sure if it is production ready

marcelloceschia avatar Jan 03 '22 17:01 marcelloceschia

@marcelloceschia Tested your build but I have some issues (I don't know if there are also present in the original build, it's the first time I try this plugin):

  • Some files are not opened in diff view when double-clicking in the list of files.
  • In that case, it is impossible to add a line-specific comment.
  • To show/hide comments, one must:
    • Click on the bubble icon
    • Then click on the commented line

Otiel avatar Jan 31 '22 12:01 Otiel

Hello @Otiel thank you for this feedback, i will try to reproduce this on weekend and give you an update

marcelloceschia avatar Jan 31 '22 18:01 marcelloceschia