Nils Haagen

Results 14 comments of Nils Haagen

From TA TechSquad today(22.09.22): the recalculation of results is still necessary, and this PRs lacks the possibility; it will have to be amended.

Thanks, @kergomard, for checking. For now, I removed this merge: https://github.com/nhaagen/ILIAS/pull/43 I'll add it later as PR to be discussed seperatedly.

> - [ ] C\ViewControl\Sortation::withHiddenLabel(): this actually forces consumers to make a design decision, which is not something we want to do. I know this method has been introduced in...

> - [x] Unit tests: the sortation view control HTML in the adjusted unit tests does not feature the components ID. Since the ID has been rendered before, could you...

@klees dunno, force-pushed and apparently the tests are back

picked https://github.com/ILIAS-eLearning/ILIAS/pull/6702

We added legacy interfaces for - ILIAS\UI\Component\Input\Field\Input - ILIAS\UI\Component\Input\Field\FilterInput - ILIAS\UI\Component\Input\ViewControl\ViewControl and marked them as deprecated for 9. That should strongly hint to necessary adjustments without breaking too much.

Hi @klees, I left ::withSelected; the idea was to (pre-)factor the control and then set the value. Although all the places I saw use the constructor over the mutator, I'd...