Niklas Hambüchen

Migration to Stack 2

2

Based on #1 by @qrilka, but I cannot push commits on that branch. Seems to work!

Make GHC base libraries dependent on GHC version.

1

See #84, #167. Done for https://github.com/nh2/static-haskell-nix/issues/53

Bad error when git clone fails

1

In #129, when `nix-prefetch-git` fails because of a too old version of nix being used, this is printed (*after* a successful clone): `error: current Nix store schema is version 10,...

Generated stack2nix output file doesn't contain tree-diff

3

When running stack2nix 0.2 on a project using `resolver: lts-9.1` (succeeds) and then trying to build the output package: ``` error: anonymous function at /nix/store/c79p3krp7li3rnc6mfjaar0n82kkxf3k-cabal2nix-Cabal/default.nix:1:1 called without required argument 'tree-diff',...

Don't use src = ./.

3

`stack2nix` currently uses `src = ./.` for the current project, which means it adds huge dirs like `.stack-work` or potentially `.git` to the build environment, resulting in ``` warning: dumping...

Runtime-dependency on cabal executable?

6

I got this: ``` Ensuring cabal version is >= 2 ... stack2nix: ERROR: cabal version must be 2 or higher. Current version: 1.22.6.0 CallStack (from HasCallStack): error, called at src/Stack2nix/Util.hs:47:49...

### TODO * [ ] Finish * [ ] Understand (see WIP commit messages) * [ ] Clean up commits * [ ] Rebase --- This change is [](https://reviewable.io/reviews/nh2/hatrace/86)

* Pick one of tasks from our general TODO list in the `README` (some of them have corresponding [issues](https://github.com/nh2/hatrace/issues) already, in such a case please assign the one you take...

Clarifications on what it means for an upload to be "finished"

2

I have a couple questions regarding the concept of uploads finishing in the spec (https://tus.io/protocols/resumable-upload.html). * The `Expiration` and `Termination` extensions talk about "finished" and "unfinished" uploads, but it is...

Write errors are ignored (chance for silent data loss)

4

`tusd` is using the `defer file.Close()` pattern that can result in silent data loss of writes since it discards the return error of `Close()`: https://github.com/tus/tusd/blob/3feef174fd14d71c121c8c263c33eb08312a9296/pkg/filestore/filestore.go#L158-L162 This means `tusd` will acknowledge...