store icon indicating copy to clipboard operation
store copied to clipboard

fix: disallow undefined in dispatch of events

Open pietzschke opened this issue 5 months ago • 3 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/ngxs/store/blob/master/CONTRIBUTING.md#commit
  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

Current implementation allows the dispatch of undefined, which does not make sense.

What is the new behavior?

Interface no longer allows undefined, only NonNullable

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

pietzschke avatar Sep 23 '24 10:09 pietzschke