store icon indicating copy to clipboard operation
store copied to clipboard

🚀[FEATURE]: More precise definition of action naming in docs

Open PendelinP opened this issue 4 years ago • 3 comments

Description

Currently the word Action is used for two things:

  1. The action class itself containing the action data (https://www.ngxs.io/concepts/actions)
  2. The implementation of the state change within the store class (https://www.ngxs.io/concepts/state#defining-actions)

This might lead to confusing discussions. Wouldn't it be nice to "rename/specify" the implementation to someting like Action Executors (since the term Action Handler is already used here: https://www.ngxs.io/advanced/action-handlers). NgRx calls such action handlers reducers which would fit as well.

What do you think? I'd love to support the project by updating the docs :)

PendelinP avatar Jun 24 '20 13:06 PendelinP

@PendelinP create pull request please as you expected action naming in docs and we help you

splincode avatar Jun 24 '20 13:06 splincode

Wow - that was fast :) Thanks a lot - will do ;)

PendelinP avatar Jun 24 '20 13:06 PendelinP

See related discussions in previous issues here: https://github.com/ngxs/store/issues/1438 https://github.com/ngxs/store/issues/125

There isn't any really decent proposal for a better name at the moment. I am open to hearing proposals (see existing ideas in the issues listed above).

PS. the use of "Action Handlers" in the docs to refer to what I call "Action Observers" (where you observe the action stream) has bugged me. It forces me to call the ones in the States "Action Hooks".

markwhitfeld avatar Nov 23 '22 22:11 markwhitfeld