core Fix service configuration with isolate = true

Fix service configuration with isolate = true

Open atiertant opened this issue 7 years ago • 11 comments

no more need to repeat setDefaultLang and use on every service in lazy loaded modules

May 02 '17 15:05 atiertant

I think this would solve #602 , #444 and #425 so seems like an important fix, could this be reviewed and merged?

Oct 09 '17 11:10 mebibou

Hmm so what does it change actually? Could I get some tests to make sure that it fixes the problem ?

Oct 09 '17 12:10 ocombe

@ocombe I don't know if it works, but the idea of not having to sync the children modules with the root one is clearly a good one. As said in my comment on another PR, the current forChild doesn't work unless we call use(lang) in every children, then sync lang changes between root and children. It's very hard to maintain and doesn't work out of the box

Oct 09 '17 12:10 mebibou

When will this be released ? Currently it doesn't work at all, to merge-load translations with lazy modules (of course you can do a workaround with setTranslation, but the recommended way should of course be via the loader...)