core icon indicating copy to clipboard operation
core copied to clipboard

refactor: switch to inject function

Open JsantosDK opened this issue 10 months ago • 2 comments
trafficstars

Following in the footsteps of Angular Components repository, I would recommend that the library switches from constructor DI to inject function DI.

Examples of this being done by the Angular team can be seen in these PR's:

  • https://github.com/angular/components/pull/30253
  • https://github.com/angular/components/pull/29775
  • https://github.com/angular/components/pull/29731
  • https://github.com/angular/components/pull/29718
  • https://github.com/angular/components/pull/29495

I'm able to make this change myself, if needed @CodeAndWeb.

JsantosDK avatar Jan 17 '25 11:01 JsantosDK

Ok... but what are the benefits for the users?

CodeAndWeb avatar Jan 29 '25 17:01 CodeAndWeb

Ideally, this wouldn't impact the users in any, it is more a maintenance task/recommendation given the direction that the angular team is taking.

JsantosDK avatar Jan 29 '25 17:01 JsantosDK