core
core copied to clipboard
Missing LICENSE file in published package
Current behavior
The published package contains the entry "license": "SEE LICENSE IN LICENSE"
its package.json
, however the LICENSE
file itself is not included.
Expected behavior
The LICENSE
file should be included in the package.
Optionally, the license
property in the package.json
should be changed from SEE LICENSE IN LICENSE
to MIT
because that matches the assigned SPDX identifier of the LICENSE
file of this repository.
How do you think that we should fix this?
Minimal reproduction of the problem with instructions
Environment
ngx-translate version: 15.0.0
Angular version: 16.0.2
For Tooling issues:
- Node version: 18.14.0
- Platform: Linux
Might be related to #1418
I want to come back to this issue. https://www.npmjs.com/package/@ngx-translate/http-loader/v/8.0.0?activeTab=code does not contain the MIT license text. It would be helpful to add the license file there. @ocombe : At least, could you confirm that version 8.0.0. is licensed under MIT? Thanks, well appreciated.
yes, the license has not changed
Merci beaucoup!
Our build and CI uses the license-webpack-plugin
to check the licenses of dependencies to ensure that only packages with allowed licenses will end up in the product. Because of this issue we have to put in licenseTypeOverrides
for the packages @ngx-translate/core
and @ngx-translate/http-loader
.