core icon indicating copy to clipboard operation
core copied to clipboard

Missing LICENSE file in published package

Open tkegelmann opened this issue 1 year ago • 5 comments

Current behavior

The published package contains the entry "license": "SEE LICENSE IN LICENSE" its package.json, however the LICENSE file itself is not included.

Expected behavior

The LICENSE file should be included in the package. Optionally, the license property in the package.json should be changed from SEE LICENSE IN LICENSE to MIT because that matches the assigned SPDX identifier of the LICENSE file of this repository.

How do you think that we should fix this?

Minimal reproduction of the problem with instructions

Environment


ngx-translate version: 15.0.0
Angular version: 16.0.2

For Tooling issues:
- Node version: 18.14.0
- Platform:  Linux

tkegelmann avatar May 24 '23 10:05 tkegelmann

Might be related to #1418

tkegelmann avatar May 24 '23 10:05 tkegelmann

I want to come back to this issue. https://www.npmjs.com/package/@ngx-translate/http-loader/v/8.0.0?activeTab=code does not contain the MIT license text. It would be helpful to add the license file there. @ocombe : At least, could you confirm that version 8.0.0. is licensed under MIT? Thanks, well appreciated.

LeChasseur avatar Jul 13 '23 13:07 LeChasseur

yes, the license has not changed

ocombe avatar Jul 13 '23 13:07 ocombe

Merci beaucoup!

LeChasseur avatar Jul 13 '23 14:07 LeChasseur

Our build and CI uses the license-webpack-plugin to check the licenses of dependencies to ensure that only packages with allowed licenses will end up in the product. Because of this issue we have to put in licenseTypeOverrides for the packages @ngx-translate/core and @ngx-translate/http-loader.

kamulos avatar Jul 25 '23 16:07 kamulos