rules icon indicating copy to clipboard operation
rules copied to clipboard

fix: Cache created view and dont call clear on ViewContainer

Open fkolar opened this issue 4 years ago • 0 comments

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ x] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

Here we can get some better performance boost. Everytime you switch between editable mode to readonly mode, I call clear on current ViewContainerRef, where all the components are destroyed and when I get back they are re-creating.

Expected behavior

I think we can do better here and instead of calling .clear() we can call detach and cache current View.

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

fkolar avatar Apr 20 '20 12:04 fkolar