lumberjack icon indicating copy to clipboard operation
lumberjack copied to clipboard

Automate Lumberjack releases

Open NachoVazquez opened this issue 3 years ago • 1 comments

The Problem

Currently, the release of the new Lumberjack version is a manual and tedious task.

The Goal

Automate the release of new versions using GH Actions.

NachoVazquez avatar Mar 12 '22 14:03 NachoVazquez

@NachoVazquez I did the same thing in one of my angular package. Here is the link:- https://github.com/patelvimal/ng-vim-devtools/blob/master/.github/workflows/npm-publish.yml

Whenever I publish using Github then this action gets triggered and will publish the package in npm.

patelvimal avatar Mar 13 '22 16:03 patelvimal

@NachoVazquez There's a new package to set all this up automatically for Nx repos: Nx-release by @kreuzerk

I recently set this up for my own project, and the steps are very simple to follow. Here's my commit for what you get after setting it up: https://github.com/ajitzero/ng-auto-animate/commit/ad28be47810dde7196389f56c2a480420425cd7e

Here are the CLI commands to run to set this up:

npm i -D nx-release
npx nx g nx-release:configure

You will need to create a GitHub Access token and an NPM access token for this repository. And that's it!

ajitzero avatar Jul 14 '23 21:07 ajitzero

Hi @ajitzero this is actually already addressed. I forgot to update the ticket. We are using https://github.com/jscutlery/semver. That said we have faced some issues with it.

I will be happy to accept a PR with the migration if you are interested.

In the meantime I will take a look at this package.

Thank you!

NachoVazquez avatar Jul 14 '23 21:07 NachoVazquez

I updated my comment above with more details. Please read again if it's at all needed, but if the current setup works fine then I don't think we should migrate anything.

ajitzero avatar Jul 14 '23 21:07 ajitzero

From what I see, we have all this covered by the package I mentioned, we were having some issues with permissions, but the link you provided gave me a few ideas about how to fix it. Thanks for sharing!

I'm going to close this issue since it is already addressed. If you think we should change something in the current workflow, feel free to create a new issue :)

NachoVazquez avatar Jul 15 '23 12:07 NachoVazquez