moksha icon indicating copy to clipboard operation
moksha copied to clipboard

deps: add logic to moksha-wallet dependencies

Open EthnTuttle opened this issue 1 year ago • 2 comments

While attempting to compile for esp32 boards using esp-rs crates, moksha-wallet couldn't be depended on because of various compile errors. When compiling for esp, you are not targeting wasm. Irconically, the wasm dependencies mostly compiled for esp. This commit adds logic so espcash can depend directly on moksha to more easily implement an ecash clinet for embedded devices.

EthnTuttle avatar Feb 27 '24 02:02 EthnTuttle

LGTM

We need an additional github Action for compiling to esp and a just task like build-esp that gets called in final-check

ngutech21 avatar Feb 27 '24 08:02 ngutech21

LGTM

We need an additional github Action for compiling to esp and a just task like build-esp that gets called in final-check

I'm going to hold off on that.

  1. I can run cargo build in the espcash repo but have yet to actually implement any logic.
  2. Compiling for esp takes a lot of extra "stuff" that I'm not ready to integrate into a GH action.

I plan to keep this branch open on my fork for development and once I get some more progress on a PoC for the embedded implementation, I'll make a task to work toward compiling and such directly within the moksha repo.

My PoC goal is a naive impl of moksha-cli but for the embedded device.

Thank you for helping sort out the dependency issues.

(ps. happy to close this PR while I work, as I anticipate this sitting open for a while)

EthnTuttle avatar Feb 27 '24 13:02 EthnTuttle