codesandbox-theme icon indicating copy to clipboard operation
codesandbox-theme copied to clipboard

Theme is not up-to-date

Open buzinas opened this issue 6 years ago • 10 comments

It seems that the theme is not up-to-date.

image

It doesn't look like with the screenshot on the README.

buzinas avatar Jul 17 '19 16:07 buzinas

That's weird, do you mind confirming you have the 1.1.3 version?

ngryman avatar Jul 17 '19 16:07 ngryman

Yup, latest version.

image

buzinas avatar Jul 17 '19 17:07 buzinas

Hey I am having the same problem Can you please figure it out?

NimishKashyap avatar Aug 09 '21 13:08 NimishKashyap

Same problem. Highlight doesn't match the theme

blasdfaa avatar Aug 17 '21 17:08 blasdfaa

Sorry for the late answer. I just published 1.2.0 with the latest changes on master. Let me know if it's 👍

ngryman avatar Aug 19 '21 13:08 ngryman

Sorry for the late answer. I just published 1.2.0 with the latest changes on master. Let me know if it's 👍

Nope, the problem remains. Everything is the same as in the screenshot above

blasdfaa avatar Aug 19 '21 13:08 blasdfaa

Got it, thanks for the quick feedback. I'll take a look then and try to publish a new version before EOW.

ngryman avatar Aug 19 '21 14:08 ngryman

Any updates on this?

vivere-dally avatar Oct 18 '21 12:10 vivere-dally

Sorry for the very late answer. Moving cities takes more energy than I thought 😅

Ok, so it seems CodeSandbox has two other themes that this extension is not providing: CodeSandbox Black and CodeSandbox Black 2021. On codesandbox.io, the default one is CodeSandbox Black which is slightly different from this one. So I guess that explains the differences mentioned here.

I added these new themes to the extension and published a 2.0.0: https://marketplace.visualstudio.com/items?itemName=ngryman.codesandbox-theme.

You now have these three themes available:

  • CodeSandbox Legacy, which is the one provided by 1.2.0. On codesandbox.io it's named CodeSandbox.
  • CodeSandbox Black which is the default one in codesandbox.io.
  • CodeSandbox Black 2021.

Hopefully, it should solve the issue. Let me know if it's 👍

ngryman avatar Oct 19 '21 15:10 ngryman

Thank you for updating the extension! Apologies if this is not the right place to ask, but would it be possible to publish the latest version on github too?

brams-dev avatar Dec 16 '21 13:12 brams-dev