store icon indicating copy to clipboard operation
store copied to clipboard

rename intial probe action from `init` to `probe`

Open fxck opened this issue 8 years ago • 3 comments

The first time to probe for an initial state if you did not provide one, the second time when Store is instantiated

https://gitter.im/ngrx/store?at=580662f3759f6d2436c41a32

fxck avatar Oct 18 '16 18:10 fxck

Looks like the probing may not be necessary soon. See ReactiveX/rxjs#2050

MikeRyanDev avatar Oct 19 '16 14:10 MikeRyanDev

Hi , sorry dude, but seriously firing"init" twice makes no sense at all and is extremely confusing/ frightening/ worrying for developers (it was for me at least).

Please change one "init" to "probe" and decide later if you want to remove probe (who came up with the name probe anyway lol).

JimLynchCodes avatar Nov 27 '16 23:11 JimLynchCodes

Looks like the RxJs issue was just merged the other day (24th), so we should be all set now. Do we need any changes to implement this? @MikeRyan52

MarkPieszak avatar Nov 27 '16 23:11 MarkPieszak