platform icon indicating copy to clipboard operation
platform copied to clipboard

feat(effects): add migrator for `concatLatestFrom`

Open rainerhahnekamp opened this issue 9 months ago • 2 comments

Adds a migrator for version 18 which replaces all concatLatestFrom imports from @ngrx/effects to @ngrx/operators.

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/ngrx/platform/blob/main/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Documentation has been added / updated (for bug fixes / features)

PR Type

Migration to @ngrx/operators

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes #4262

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

rainerhahnekamp avatar May 01 '24 20:05 rainerhahnekamp

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
Latest commit d684d778be880e6c80e0f446d1a66ae7ef7f856d
Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/663a9651e544d60008961d11

netlify[bot] avatar May 01 '24 20:05 netlify[bot]

@markostanimirovic I'd suggest we make this one first and it will serve as a template for the component-store migrator

rainerhahnekamp avatar May 01 '24 20:05 rainerhahnekamp

@markostanimirovic if possible, I'd like to push the version that includes the fix of https://github.com/ngrx/platform/pull/4311#discussion_r1589989821 before this is merged.

rainerhahnekamp avatar May 07 '24 11:05 rainerhahnekamp

@markostanimirovic if possible, I'd like to push the version that includes the fix of #4311 (comment) before this is merged.

sounds good!

markostanimirovic avatar May 07 '24 11:05 markostanimirovic