platform icon indicating copy to clipboard operation
platform copied to clipboard

fix(component-store): move isInitialized check to queueScheduler context on state update

Open markostanimirovic opened this issue 3 years ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2991

What is the new behavior?

There is no initialization error when ComponentStore initialization and state update are scheduled via queueScheduler.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR currently depends on #3490

markostanimirovic avatar Jul 16 '22 00:07 markostanimirovic

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
Latest commit d997c1ce980ff43074353d0dd1de578f1f47acfc
Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/62fc19b40f29f900097e50ad

netlify[bot] avatar Jul 16 '22 00:07 netlify[bot]