platform
platform copied to clipboard
ngrx
docs(data): add tour of heroes demo app
PR Checklist
Please check if your PR fulfills the following requirements:
- [x] The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
- [] Tests for the changes have been added (for bug fixes / features)
- [x] Documentation has been added / updated (for bug fixes / features)
PR Type
What kind of change does this PR introduce?
[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:
What is the current behavior?
Closes #3004
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No
Other information
Did do too much rewriting of the app, mostly just a port from the original repo.
Preview docs changes for f5b2e513 at https://previews.ngrx.io/pr3131-f5b2e513/
@yharaskrik
I think we need Tour of Heroes app with @ngrx/data included, not the starter version. 🤔 Version with @ngrx/data is on finish branch of ngrx-data-lab repo.
Hmm somehow nx.json was formatted but nx format doesn't change it back, should I go in there and edit the file to remove that formatting?
Haha thanks Marko! I'll work on this tonight. I think the other example app has strict disabled so figured it was fine for here as well. I did do a literally copy paste so there's probably a lot of easy cleanup to be done.
Yup! I still gotta work on Markos suggestions too it seems, work has a strangle hold on me right now! Ill get the changes and conflicts done soon hopefully.
Going to close this one for now. Feel free to reopen or open a new one when ready
@yharaskrik Would you like to re-open this PR with applied suggestions? 👀
If you don't have time, I can take care of it.
@yharaskrik Would you like to re-open this PR with applied suggestions? 👀
If you don't have time, I can take care of it.
I can take a look! Although it does not seem that I can reopen it! Can you reopen for me please and thanks!
