core icon indicating copy to clipboard operation
core copied to clipboard

move lib to src for consistency

Open robwormald opened this issue 8 years ago • 3 comments

robwormald avatar Jun 22 '16 23:06 robwormald

Are you wanting it to be consistent across all ngrx projects? If that's the case, we'll need to update router, router-store, effects, notify, store-devtools, and store-log-monitor as well.

MikeRyanDev avatar Jul 05 '16 20:07 MikeRyanDev

Yeah, I'd like to be consistent across projects and implement this proposal:

https://github.com/dherman/defense-of-dot-js/blob/master/proposal.md

TS source in /src Output commonJS ES5 to the root Output standard (ES) modules to /lib Add module and modules.root to point to ESM entry point and modules

We'll implement the same in @angular and build our es module pipeline around it.

Thoughts?

robwormald avatar Jul 05 '16 21:07 robwormald

Sounds good. To be clear, the ES modules we output to /lib need to be ES5 with ES6 modules, correct?

MikeRyanDev avatar Jul 08 '16 01:07 MikeRyanDev