kubernetes-ingress-controller icon indicating copy to clipboard operation
kubernetes-ingress-controller copied to clipboard
verified publisher icon ngrok

add golangci-lint to make test

Open jrobsonchase opened this issue 2 years ago • 4 comments

What

Describe what the change is solving

How

Describe the solution

Breaking Changes

Are there any breaking changes in this PR?

jrobsonchase avatar May 16 '23 18:05 jrobsonchase

Current dependencies on/for this PR:

  • main
    • PR #227 Graphite
      • PR #229 Graphite
        • PR #230 Graphite
          • PR #231 Graphite 👈
      • PR #228 Graphite

This comment was auto-generated by Graphite.

jrobsonchase avatar May 16 '23 18:05 jrobsonchase

Welp, no clue why the build job won't run :shrug:

jrobsonchase avatar May 16 '23 18:05 jrobsonchase

Hm, still not running :thinking:

jrobsonchase avatar May 23 '23 18:05 jrobsonchase

Looks like it eventually ran, seeing the linting lines: https://github.com/ngrok/kubernetes-ingress-controller/actions/runs/5060657393/jobs/9083840896?pr=231

bobzilladev avatar May 23 '23 18:05 bobzilladev