Nathan Goldbaum
Nathan Goldbaum
@clin1234 can you close this? its fixed now.
Argh, there are deeper issues with this. I can't actually recover the no-op semantics on the GIL-enabled build. The key difference is that in Rust, the mutexes are wrapper types....
I marked this ready for review but I expect it to have at least one more round. I left a couple questions for others and comments for myself inline.
I think the last push satisfies all your comments and concerns.
I think tests are green now. I also added a release note for the moved functions.
Just a note that this should probably only be merged once all the "RuntimeWarning: The global interpreter lock (GIL) has been enabled to load module foo" warnings in the python...
> Just a note that this should probably only be merged once all the "RuntimeWarning: The global interpreter lock (GIL) has been enabled to load module foo" warnings in the...
This probably needs some discussion in the new guide section on free-threading support.
woohoo! looks like tests are passing except for the codecov issue affecting all PRs right now.
It occurred to me while working on something else that this PR should remove the `UNSAFE_PYO3_BUILD_FREE_THREADED` uses in the CI scripts a well. EDIT: done