Nathan Goldbaum comments

Results 755 comments of


                                            Nathan Goldbaum

limit to Python <= 3.12 - for now - until all our required deps support Python 3.13 free-threaded ABI

This issue is about free-threaded Python - I don't think you set up tests for that unless I'm missing something in your links. Cryptography 26.0.0 supports free-threaded Python 3.14, so...

limit to Python <= 3.12 - for now - until all our required deps support Python 3.13 free-threaded ABI

Because otherwise your users might hit issues that are only possible under the free-threaded build. In particular, behaviors that happen when using the library in threads. IMO all libraries that...

MAINT: use an atomic load and mutex to initialize the argparse and runtime import caches

Hmm, it looks like whichever version of gcc is available for the manylinux2014 32bit build doesn't have C11 atomics support. I have no idea if I should go out of...

MAINT: use an atomic load and mutex to initialize the argparse and runtime import caches

> however C11 atomics are optional right? That's right. > So do we have a sense what other platforms/compilers not tested in our CI don't support it? gcc 4.9 was...

MAINT: use an atomic load and mutex to initialize the argparse and runtime import caches

It looks like CPython doesn't account for any compilers besides clang, gcc, and MSVC. It supports older clang and gcc versions using the gcc builtin atomics support provided prior to...

MAINT: use an atomic load and mutex to initialize the argparse and runtime import caches

I re-added the libatomic test in the meson configuration and also added some uint8 operations to the linking test as well since @colesbury pointed out that GCC under RISC-V has...

MAINT: use an atomic load and mutex to initialize the argparse and runtime import caches

> did you see that PyMutex is now exposed publicly? I'm not sure if that makes any of this easier. I saw that! It does make some things easier (no...

MAINT: use an atomic load and mutex to initialize the argparse and runtime import caches

@colesbury can you explain more why it's not thread safe with the lock? I thought I only needed one atomic load to serialize acquiring the lock.

MAINT: use an atomic load and mutex to initialize the argparse and runtime import caches

OK, the last commit reworks the import cache to use atomic loads and stores on the pointer directly. I also added the necessary atomic loads and stores for the argparse...

ENH: Support free-threaded python build (tracking issue)

It looks like numpy's main branch passes the full numpy test suite with the gil disabled. I've been testing using the `nogil-integration` branch in @colesbury's fork of CPython, but i...