Nathan Goldbaum
Nathan Goldbaum
> I am starting to think it is time to implement a get_sortfunction slot Agreed. @MaanasArora as you said this was a draft, would you be up for a bigger...
> adding a slot to the dtype will mean we will restructure the sorting to be more generic and allow replacing or extending compare etc.? Take a look at `numpy/_core/src/multiarray/dtypemeta.h`...
Yeah, I think you see we still have a lot of other functionality that we should have slots for. Definitely nonzero, at least.
Sorry for not getting to this yet. I'm going to try to make sure to give this a once-over next week. I think you can fix the test failures by...
I want to call your attention to this suggestion: https://github.com/numpy/numpy/pull/28516#discussion_r2016850556. Did you ever take a look at numpy-user-dtypes? A worked example would help.
Just a head's up I haven't forgotten about this. I'm planning to spend some time later this week or next looking closely at this and the accompanying numpy-user-dtypes PR. Thanks...
Test failure is unrelated. @MaanasArora I don't remember the status of this PR - is it ready on your end to be reviewed or do you still have more work...
I see 3.13 support is being tracked over at https://github.com/mypyc/mypyc/issues/1056.
I wonder if there's a reference counting bug. It would be interesting to compile a debug build of Python so you can check that [`sys.gettotalrefcount()`](https://docs.python.org/3/using/configure.html#python-debug-build) isn't monotonically increasing as you...
Added sprintable label because this seems like it would be fun to investigate and understand what's happening better in a sprint.