hotkeys icon indicating copy to clipboard operation
hotkeys copied to clipboard

Better Icon for Enter / configurable icons in HotkeysHelpComponent

Open youseeus opened this issue 3 years ago • 2 comments

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

The enter icon (⌤) in the HotkeysHelpComponent is not recognized by our users.

Expected behavior

It would be nice if the icon is changed if the Device is not a Apple-Device or if we can configure the icon or if it is replaced by just 'enter'

Minimal reproduction of the problem with instructions

open the HotkeysHelpComponent when a shortcut with 'enter' is added.

Environment


Angular version: 14.2.2

Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [x] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [x] Edge version XX

Others: 
 - [x] Windows

youseeus avatar Sep 20 '22 08:09 youseeus

https://github.com/ngneat/hotkeys/commit/dbd3780ea416ca746e0fb0e4484c59e81d763cb2

youseeus avatar Sep 20 '22 08:09 youseeus

You're welcome to create a PR.

NetanelBasal avatar Dec 17 '22 17:12 NetanelBasal