elf icon indicating copy to clipboard operation
elf copied to clipboard

feat(entities): add entities actions

Open 5im0n opened this issue 2 years ago • 5 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [X] The commit message follows our guidelines: https://github.com/ngneat/elf/blob/master/CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

First attempt to add Entities Action in Elf, related to the issue: https://github.com/ngneat/elf/issues/247

Issue Number: https://github.com/ngneat/elf/issues/247

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

5im0n avatar May 03 '22 14:05 5im0n

Let me know when I can recheck it, please.

NetanelBasal avatar May 07 '22 19:05 NetanelBasal

@5im0n what's the status?

NetanelBasal avatar May 21 '22 19:05 NetanelBasal

Is there any progress? @5im0n

mehmet-erim avatar May 24 '22 10:05 mehmet-erim

Hey @NetanelBasal,

I'm pretty busy right now, In my last commit 3 weeks ago, I added the unit test.

You can check the MR, I'll add the documentation after

5im0n avatar May 30 '22 11:05 5im0n

You have TODOS in the code. No rush. I just wanted to know the status.

NetanelBasal avatar May 30 '22 11:05 NetanelBasal