dialog icon indicating copy to clipboard operation
dialog copied to clipboard

[FR] Possibility to add additional classes (from code) to the ngneat-modal-content element to allow sizing via Bootstrap col-*, col-[sm|md|lg|xl]-* classes

Open hidegh opened this issue 4 years ago • 3 comments

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

Setting styles via Bootstrap classes is not possible.

Expected behavior

Using col col-sm-x classes.

Change needed is minimum:

  1. Add a possibility to set additional classes on the ngneat-dialog-content element
  2. remove the ngneat-dialog-content width: auto style
  3. make possible to avoid forcing height/width styles (especially if the size is not set = or at least when we set it to an empty string)

Minimal reproduction of the problem with instructions


What is the motivation / use case for changing the behavior?

Ease of use, flexibility.

Environment


Angular version: X.Y.Z


Browser:
- [x] Chrome (desktop) version latest
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  Windows

Others:

hidegh avatar May 13 '21 17:05 hidegh

Would probably add this also as a default: Let the custom component fill the entire dialog (in case it's fluidly designed)

.ngneat-dialog-content {
  > * {
    display: flex;
    flex: 1 1 auto;
  }
}

hidegh avatar May 13 '21 17:05 hidegh