bind-query-params icon indicating copy to clipboard operation
bind-query-params copied to clipboard

feat: 🎸 added option to handle prev/next button in the browser

Open akaNightmare opened this issue 1 year ago • 6 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [x] The commit message follows our guidelines: CONTRIBUTING.md#commit
  • [x] Tests for the changes have been added (for bug fixes / features)
  • [x] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

closes https://github.com/ngneat/bind-query-params/issues/13

akaNightmare avatar Jun 19 '23 19:06 akaNightmare

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

stackblitz[bot] avatar Jun 19 '23 19:06 stackblitz[bot]

Please add test

NetanelBasal avatar Jun 20 '23 05:06 NetanelBasal

@NetanelBasal done

akaNightmare avatar Jun 20 '23 18:06 akaNightmare

@shaharkazaz please check this

NetanelBasal avatar Jun 20 '23 19:06 NetanelBasal

:)

akaNightmare avatar Jun 27 '23 06:06 akaNightmare

@akaNightmare didn't forget that, I'm on vacation 😀 I'll review once I get back

shaharkazaz avatar Jun 27 '23 06:06 shaharkazaz