ngl icon indicating copy to clipboard operation
ngl copied to clipboard

Hiding a component does not hide its picking selections or its measurements

Open Treppenhouse opened this issue 7 years ago • 1 comments

The problem occurs when making a measurement or picking/selecting elements and the green bubbles are displayed. When I then hide the component via the eye button, those bubbles are still there, along with the measurements.

Before hiding: ngl1

After hiding: ngl2

Expected behaviour: I would expect that selection bubbles would be hidden together with the component. Regarding the measurements I can see that it might make sense to keep them displayed, but I don't see the point of keeping the selection bubbles.

Suggestion: In the structure-components.ts one could override the setVisibility() method like this:

  setVisibility (value: boolean) {
    super.setVisibility(value);

    this.measureRepresentations.setVisibility(value);
    this.spacefillRepresentation.setVisibility(value);

    return this;
  }

If you agree, then I can create a merge request for this.

Treppenhouse avatar Oct 18 '18 15:10 Treppenhouse

Sounds good,please do a PR, thanks!

arose avatar Jan 07 '19 21:01 arose