OverlayPlugin icon indicating copy to clipboard operation
OverlayPlugin copied to clipboard

added Buffs to GetCombatants

Open jrsmile opened this issue 3 years ago • 1 comments

chat result with valarin about missing information compared to EnmityAggroList, should allow to get the same information when combining PartyChanged event and GetCombatants as EnmityAggroList.

A EnmityPartyList would still be better.

jrsmile avatar Sep 08 '21 13:09 jrsmile

Sorry for taking so long...

I don't like adding Effects as a supported property since unlike the other fields, it's not a primitive type. However, the new parser for 6.0 replaces that field with NetworkBuffs so I'd rather wait until then and add the new field (if the JSON encoder can handle it) instead of the old Effects field.

Long term, a better solution would be to remove the current PartyChanged and GetCombatants implementations and replace them with the custom memory logic that's used for EnmityAggroList. For context: PartyChanged and GetCombatants use data from the FFXIV parser (which doesn't keep track of enmity) and EnmityAggroList reads data directly from the game's memory. This allows the latter to read enmity as well but requires more maintenance.

ngld avatar Nov 19 '21 23:11 ngld