OverlayPlugin icon indicating copy to clipboard operation
OverlayPlugin copied to clipboard

Add additional supported fields to IOverlayPreset

Open quisquous opened this issue 5 years ago • 2 comments

quisquous avatar Sep 12 '20 21:09 quisquous

I am not sure this approach is reasonable, because how do downstream dependencies that are using the IOverlayPreset supposed to compile? Do they need to be updated ahead of time?

Another alternative is to add more strings into Supports, but that felt a little bit hacky.

Do you have suggestions on better ways to get at this? Maybe RegisterOverlayPreset could take a JObject instead of an IOverlayPreset as a way to have a looser coupling?

quisquous avatar Sep 12 '20 21:09 quisquous

Using JObjects sounds like a good solution. The default presets are already read through Newtonsoft.Json, I'd have to modify the code that parses the JSON data but then I could use it for both RegisterOverlayPreset and the presets.json file.

Oh, and sorry for the late response. I didn't check GitHub for the past two months...

ngld avatar Dec 10 '20 21:12 ngld