cmake-wix-testsuite icon indicating copy to clipboard operation
cmake-wix-testsuite copied to clipboard

Execute after InstallFinalize

Open dlrdave opened this issue 6 years ago • 1 comments

InstallFiles only schedules files to be installed, and occurs before the files actually exist on disk. Waiting until after InstallFinalize allows running installed files. Changing the condition to "NOT Installed" makes it execute if the installer starts without the program being installed, and then actually installs it. It does not execute during a "repair" / "reinstall" operation.

dlrdave avatar Jan 10 '19 15:01 dlrdave

Hi! Thanks for the pull request. I don't currently have a windows development system set up to test any of this and I haven't really expected any pull requests since I only ever used this repository to test my changes to the WIX generator; I might get around merging this if I ever get back to actually having to run these though.

FWIW as far as I can tell this specific test case I only added to see if the conditional ends up in the generated WIX source files (there was a bug in the generator that resulted in text nodes being omitted).

Are you sure about InstallFiles only scheduling though?

As far as I can tell from https://docs.microsoft.com/en-us/windows/desktop/msi/installfiles-action it performs the actual copying(?).

ngladitz avatar Jan 10 '19 18:01 ngladitz