nginx-s3-gateway icon indicating copy to clipboard operation
nginx-s3-gateway copied to clipboard

Published 20 hours ago • verified publisher icon nginxinc

feature: add CORS_ALLOW_PRIVATE_NETWORK_ACCESS env var

Open danielcompton opened this issue 2 years ago • 7 comments

Fixes #180.

danielcompton avatar Oct 16 '23 19:10 danielcompton

Hi @danielcompton thank you for you contribution and the thorough description in the issue. I agree that this is a good feature for us to provide and the env var name you chose pairs well with our existing CORS_ options.

Give me a moment to review and test and I think we can get this merged 🤘

4141done avatar Oct 17 '23 16:10 4141done

@4141done sorry for the delay on this. I've updated the code, tested that it works locally, and also updated some other parts of the Dockerfiles and scripts that I think also needed to be updated.

danielcompton avatar May 02 '24 18:05 danielcompton

Hi there @danielcompton!

We have changed the base branch of the repo since your original commits -- I edited the PR to target the new base branch (main) but it looks like there are some merge conflict. Can you update the PR when you get a chance?

Thanks!

alessfg avatar May 03 '24 11:05 alessfg