nginx-prometheus-exporter icon indicating copy to clipboard operation
nginx-prometheus-exporter copied to clipboard

Published 20 hours ago • verified publisher icon nginxinc

Fix typographical error

Open rwenz3l opened this issue 2 years ago • 1 comments

Remove a duplicate "that were" in metric description

Proposed changes

While adding metrics from the README to our grafana dashboards I found a small error in the description. This fixes just that.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [x] I have read the CONTRIBUTING guide
  • [x] I have proven my fix is effective or that my feature works
  • [ ] I have checked that all unit tests pass after adding my changes
  • [x] I have ensured the README is up to date
  • [ ] I have rebased my branch onto main
  • [ ] I will ensure my PR is targeting the main branch and pulling from my branch on my own fork

rwenz3l avatar Aug 17 '22 08:08 rwenz3l

Hi @rwenz3l

thanks for the PR! I noticed that the same typo is in the code as well here https://github.com/nginxinc/nginx-prometheus-exporter/blob/main/collector/nginx_plus.go#L349 do you want to update it there too? Or I can add a commit to this PR, let me know.

lucacome avatar Aug 17 '22 18:08 lucacome

@rwenz3l I fixed the other typo and I'm merging this. Thanks again! 🎉

lucacome avatar Aug 27 '22 02:08 lucacome