nginx-prometheus-exporter icon indicating copy to clipboard operation
nginx-prometheus-exporter copied to clipboard

provide TLS feature using Prometheus community exporter-toolkit web

Open lucian-vanghele opened this issue 4 years ago • 6 comments

Proposed changes

Have a unified way to provide tls configuration by using exporter-toolkit from Prometheus community.(https://github.com/prometheus/exporter-toolkit/blob/master/docs/web-configuration.md). For this exporter is beneficial to rely on a big community. For teams using multiple exporters it helps to do things same way.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [x] I have read the CONTRIBUTING guide
  • [x] I have proven my fix is effective or that my feature works
  • [x] I have checked that all unit tests pass after adding my changes
  • [x] I have ensured the README is up to date
  • [x] I have rebased my branch onto master
  • [x] I will ensure my PR is targeting the master branch and pulling from my branch on my own fork

lucian-vanghele avatar Nov 17 '21 16:11 lucian-vanghele

Will it bring both TLS and Basic Auth support?

hrw avatar Mar 08 '22 11:03 hrw

it will bring everything included in the exporter-toolkit/web

lucian-vanghele avatar Mar 09 '22 13:03 lucian-vanghele

Hi @lucian-vanghele thanks for the PR and sorry for the long delay. Would you mind rebasing your branch (and fixing the conflicts) so I can start testing this? Thanks!

lucacome avatar Mar 11 '22 01:03 lucacome

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 05 '22 02:08 github-actions[bot]

Hi @lucian-vanghele thanks for the PR and sorry for the long delay. Would you mind rebasing your branch (and fixing the conflicts) so I can start testing this? Thanks!

@lucacome sorry for delay. can you please check?

lucian-vanghele avatar Aug 05 '22 11:08 lucian-vanghele

thanks for the comments. regarding exporter toolkit status please see https://github.com/prometheus/exporter-toolkit/issues/45 so I think experimental part is pretty obsolete by now. (and yes, the package is used in a lot of exporters)

I'll take a look at the other comments.

lucian-vanghele avatar Aug 30 '22 08:08 lucian-vanghele