nginx-gateway-fabric icon indicating copy to clipboard operation
nginx-gateway-fabric copied to clipboard

Data Race issue in unit tests run by github pipeline

Open bjee19 opened this issue 5 months ago • 1 comments

Github pipeline unit tests occasionally fail due to Data Race issues.

Examples:

  • https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/10908395436/job/30274342711?pr=2568#step:4:5123
  • https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/10855036901/job/30126828250?pr=2546#step:4:2771
  • https://github.com/nginxinc/nginx-gateway-fabric/actions/runs/10929251093/job/30339638261?pr=2574#step:4:5451

Notes: Could be related to the parallelization recently added to tests:

  • https://github.com/nginxinc/nginx-gateway-fabric/pull/2537
  • https://github.com/nginxinc/nginx-gateway-fabric/pull/2534
  • https://github.com/nginxinc/nginx-gateway-fabric/pull/2533
  • https://github.com/nginxinc/nginx-gateway-fabric/pull/2493
  • https://github.com/nginxinc/nginx-gateway-fabric/pull/2367
  • https://github.com/nginxinc/nginx-gateway-fabric/pull/2362
  • https://github.com/nginxinc/nginx-gateway-fabric/pull/2361

May be able to use the go-lang built in race detector: https://go.dev/doc/articles/race_detector

bjee19 avatar Sep 17 '24 18:09 bjee19