nginx-gateway-fabric
nginx-gateway-fabric copied to clipboard
Add baseHTTPConfig to NginxProxy to allow disabling HTTP2
Proposed changes
Problem: We need a way to allow a user to disable HTTP2
Solution: Extend the NginxProxy CRD to include a BaseHTTPConfig which will include all http context level directives that should apply to all servers.
Testing: Unit and local testing, confirmed that the http2 directive is set correctly unless disabled. If disabled, confirmed that a condition is added to any GRPCRoutes.
Please focus on (optional):
This is a draft PR to get feedback. Please focus on the approach, in particular the API definition, naming etc.
Full unit test coverage isn't complete yet.
Closes #1858
Checklist
Before creating a PR, run through this checklist and mark each as complete.
- [ ] I have read the CONTRIBUTING doc
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] I have checked that all unit tests pass after adding my changes
- [ ] I have updated necessary documentation
- [ ] I have rebased my branch onto main
- [ ] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes, please add a brief note that summarizes the change.
Added configuration option to disable HTTP2 to the NginxProxy CRD
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.96%. Comparing base (
869ac38) to head (1e02137).
Additional details and impacted files
@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
+ Coverage 86.90% 86.96% +0.05%
==========================================
Files 88 89 +1
Lines 6056 6083 +27
Branches 50 50
==========================================
+ Hits 5263 5290 +27
Misses 741 741
Partials 52 52
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.