nginx-gateway-fabric icon indicating copy to clipboard operation
nginx-gateway-fabric copied to clipboard

GRPCRouteFilter Request HTTPHeaderFilter for GRPCRouteRule

Open mpstefan opened this issue 1 year ago • 3 comments
trafficstars

As a user of NGF with applications that require GRPC traffic I want NGF to support a GRPCRouteRule that can handle a request HTTPHeaderFilter So that I can append specific headers required by my applications.

Acceptance

  • A user can specify a GRPCRouteFilter in their GRPC routes.
  • The GRPCRouteFilter can be of type "RequestHeaderModifier" as defined here.
  • A user can specify a request HTTPHeaderFilter in their GRPCRouteFilter which works as specified here.

mpstefan avatar Mar 25 '24 15:03 mpstefan

Can we leverage the existing HTTPHeaderFilter for HTTPRouteFilters here?

responseHeaderModifier is marked as Extended in the GRPCRouteFilter, but Core in the GRPCRouteFilter types. Do we implement?

mpstefan avatar Apr 01 '24 14:04 mpstefan

@mpstefan I'm going to address requestHeaderModifier only as part of this ticket, as support for responseHeaderModifier for HTTPRoute (which 95% covers the support for GRPCRoute) is already covered in #1397. I think that ticket can probably be used to track responseHeaderModifier filter support for both Route types (or maybe another ticket would be better, but if so, #1397 should still go first).

ciarams87 avatar Apr 30 '24 20:04 ciarams87

Sounds good! Glad we can reuse #1397 here.

mpstefan avatar May 02 '24 14:05 mpstefan